Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix counting plugins migrated, Doctor JSON schema and multi-word command verbs reporting #1182

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Fix counting plugins migrated, Doctor JSON schema and multi-word command verbs reporting #1182

merged 4 commits into from
Aug 10, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Aug 10, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Improve Doctor JSON schema
  • Fix counting plugins migrated via migrate command
  • Anonymize multi-word command reporting
  • Remove time.Sleep from testing

@pkosiec pkosiec added the bug Something isn't working label Aug 10, 2023
@pkosiec pkosiec added this to the v1.3.0 milestone Aug 10, 2023
@pkosiec pkosiec marked this pull request as ready for review August 10, 2023 15:26
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners August 10, 2023 15:26
@pkosiec pkosiec requested a review from mszostok August 10, 2023 15:26
@pkosiec pkosiec changed the title Fix counting plugins migrated, improve Doctor JSON schema Fix counting plugins migrated, Doctor JSON schema and multi-word command verbs reporting Aug 10, 2023
huseyinbabal
huseyinbabal approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test results 👇

Command

Screenshot 2023-08-10 at 18 57 39

Log

Screenshot 2023-08-10 at 18 58 07

Command

Screenshot 2023-08-10 at 18 57 50

Log

Screenshot 2023-08-10 at 18 58 24

@pkosiec pkosiec enabled auto-merge (squash) August 10, 2023 16:03
@pkosiec pkosiec merged commit a1ef14f into kubeshop:main Aug 10, 2023
13 checks passed
@pkosiec pkosiec deleted the fix-command-analytics branch August 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

@mszostok mszostok Awaiting requested review from mszostok mszostok is a code owner automatically assigned from kubeshop/botkube-dev

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @huseyinbabal