Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config get CLI command #1208

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Add config get CLI command #1208

merged 3 commits into from
Aug 30, 2023

Conversation

mszostok
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add config get CLI command

Testing

  1. Build CLI: go build -o /usr/local/bin/botkube ./cmd/cli
  2. Run: botkube config get or botkube config get -ojson or botkube config get -v

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Aug 24, 2023
@mszostok mszostok force-pushed the add-get-cfg branch 4 times, most recently from 2a32ec8 to c64756e Compare August 24, 2023 20:48
@mszostok mszostok marked this pull request as ready for review August 25, 2023 08:39
@mszostok mszostok requested review from PrasadG193 and a team as code owners August 25, 2023 08:39
huseyinbabal
huseyinbabal approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 🚀 . You can ping me if you add something related to cloud, I can re-test it against cloud
Screenshot 2023-08-28 at 13 00 54
Screenshot 2023-08-28 at 13 02 12

@mszostok mszostok force-pushed the add-get-cfg branch 2 times, most recently from e2fbfea to cceed73 Compare August 29, 2023 11:28
@mszostok
Copy link
Contributor Author

@huseyinbabal thanks for the first review, I added cloud support in c59ffe1

Let me know if it works for you and if I can merge it 👍

@huseyinbabal
Copy link
Contributor

@huseyinbabal thanks for the first review, I added cloud support in c59ffe1

Let me know if it works for you and if I can merge it 👍

Re-tested, works as expected

Screenshot 2023-08-30 at 14 22 46

@mszostok mszostok merged commit 0da68dd into kubeshop:main Aug 30, 2023
13 checks passed
@mszostok mszostok deleted the add-get-cfg branch August 30, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

@huseyinbabal huseyinbabal Awaiting requested review from huseyinbabal

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @huseyinbabal