Elasticsearch v8 Support #1215
Merged
Elasticsearch v8 Support #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
approved these changes
Aug 30, 2023
pkg/sink/elasticsearch.go
Outdated
Comment on lines
165
to
171
| if err != nil && err.(*elastic.Error).Details.Type != "resource_already_exists_exception" { | ||
| return fmt.Errorf("while creating index: %w", err) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if err != nil && err.(*elastic.Error).Details.Type != "resource_already_exists_exception" { | |
| return fmt.Errorf("while creating index: %w", err) | |
| } | |
| if err != nil && elastic.ErrorReason(err) != "resource_already_exists_exception" { | |
| return fmt.Errorf("while creating index: %w", err) | |
| } |
BTW please move this reason to consts 👍
pkosiec
approved these changes
Aug 30, 2023
pkg/sink/elasticsearch.go
Outdated
| return fmt.Errorf("while creating index: %w", err) | ||
| } | ||
| } | ||
|
|
||
| // Send event to els | ||
| _, err = e.client.Index().Index(indexName).Type(indexCfg.Type).BodyJson(event).Do(ctx) | ||
| indexService := e.client.Index().Index(indexName) | ||
| if strings.HasPrefix(e.clusterVersion, "7.") { |
There was a problem hiding this comment.
BTW, shouldn't we also check for versions below? E.g. 6? WDYT?
Maybe we can split this string by ., parse the first item as int and see whether is 7 or below?
There was a problem hiding this comment.
That's a good question :) Let me add check for that
pkosiec
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
v8 Test
v7 Test
In both tests, you shouldn't see 400 errors.
Related issue(s)
#887