Fix schemas for gh-events and flux, fix render in gh-events #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
fix-gh
branch
2 times, most recently
from
43f59aa
to
ebe7326
Compare
mszostok
commented
Sep 4, 2023
| "auth": { | ||
| "accessToken": { | ||
| "ui:widget": "password", | ||
| "ui:help": "Hint: Make it strong!" |
There was a problem hiding this comment.
Suggested change
| "ui:help": "Hint: Make it strong!" |
There was a problem hiding this comment.
remember about removing the comma after removing the line 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
As described here: https://docs.botkube.io/usage/executor/flux#simplified-kustomization-diffing-flow
FYI: changes are already published to
app.botkube.ioplease use it during testing. I had to do it as the important flux tutorial will be promoted today. And based on Maria feedback we already got traction on this integration so we need to have it working e2e.Issue
Fix #1222