Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e perf #1227

Merged
merged 18 commits into from
Sep 7, 2023
Merged

Improve e2e perf #1227

merged 18 commits into from
Sep 7, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Added cache for CLI build
  • Removed unnecessary binary builds

Testing

I tested steps (excluding e2e tests, since I don't have setup in my forked repo), and saw the reasonable drop in timings. https://github.com/huseyinbabal/botkube/actions/runs/6049879422

Related issue(s)

@huseyinbabal huseyinbabal requested review from PrasadG193 and a team as code owners September 4, 2023 10:34
@huseyinbabal huseyinbabal linked an issue Sep 4, 2023 that may be closed by this pull request
@huseyinbabal huseyinbabal added enhancement New feature or request ci Related to CI pipelines labels Sep 4, 2023
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job 🚀

Let's see the e2e results after merging 🙂

.github/workflows/pr-build.yaml Outdated Show resolved Hide resolved
@huseyinbabal huseyinbabal enabled auto-merge (squash) September 7, 2023 08:14
@huseyinbabal huseyinbabal merged commit 8957f04 into kubeshop:main Sep 7, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to CI pipelines enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve e2e ci performance
2 participants