Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add report - connection init (botVer, k8sVer) #1257

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Add report - connection init (botVer, k8sVer) #1257

merged 4 commits into from
Sep 14, 2023

Conversation

madebyrogal
Copy link
Contributor

@madebyrogal madebyrogal commented Sep 13, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • add report connection init (send botVer & k8sVer)

Testing

  • run agent (connected with cloud deployment)
  • check if it reports new status connecting
  • check if it reports botVer & k8sVer (deployment_status)

Related issue(s)

@madebyrogal madebyrogal requested review from PrasadG193 and a team as code owners September 13, 2023 14:38
@madebyrogal madebyrogal added the enhancement New feature or request label Sep 13, 2023
@madebyrogal madebyrogal changed the title add report deployment connection init (botVer, k8sVer) Add report - connection init (botVer, k8sVer) Sep 13, 2023
mszostok
mszostok reviewed Sep 13, 2023
View reviewed changes
cmd/botkube-agent/main.go Outdated Show resolved Hide resolved
internal/status/gql_reporter.go Outdated Show resolved Hide resolved
internal/status/gql_reporter.go Outdated Show resolved Hide resolved
internal/status/reporter.go Outdated Show resolved Hide resolved
@mszostok mszostok merged commit 51e18b9 into kubeshop:main Sep 14, 2023
14 checks passed
pkosiec pushed a commit to pkosiec/botkube that referenced this pull request Sep 14, 2023
@madebyrogal @pkosiec
Add report - connection init (botVer, k8sVer) (kubeshop#1257)
f4d5f25 
(cherry picked from commit 51e18b9)
pkosiec pushed a commit that referenced this pull request Sep 14, 2023
@madebyrogal @pkosiec
Add report - connection init (botVer, k8sVer) (#1257)
9d05996 
(cherry picked from commit 51e18b9)
@madebyrogal madebyrogal deleted the agent-report-connecting branch September 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madebyrogal @mszostok