-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Healthz improve endpoint #1276
Healthz improve endpoint #1276
Conversation
dd0705b
to
f67298d
Compare
3a08311
to
4bebb76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall code LGTM 👍 but there are a few things that need to be fixed before merged 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Please apply the two final comments before merging :)
improve health package
e1ead16
to
60038a5
Compare
* decouple health package from main.go * get plugins health improve health package * get bot status * fix test add method description * fix lint * fix tests * add sink type platforms to status * show plugin config name in healthz * additional unhealthy condition * fix CR * add tests * fix status in slack cloud * fix CR
* decouple health package from main.go authored-by: Tomasz Rogalski <[email protected]>
Description
Changes proposed in this pull request:
Testing
Related issue(s)
#890