Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthz improve endpoint #1276

Merged
merged 13 commits into from
Oct 6, 2023

Conversation

madebyrogal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • add more details to healthz endpoint

Testing

  • make bot connected to all available platforms
  • run bot-agent and trigger /healthz endpoint

Related issue(s)

#890

@madebyrogal madebyrogal requested review from PrasadG193 and a team as code owners September 27, 2023 11:19
@madebyrogal madebyrogal added the enhancement New feature or request label Sep 27, 2023
@madebyrogal madebyrogal force-pushed the healthz-improve-endpoint branch 2 times, most recently from 3a08311 to 4bebb76 Compare October 2, 2023 10:19
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall code LGTM 👍 but there are a few things that need to be fixed before merged 👍

pkg/bot/slack_cloud.go Outdated Show resolved Hide resolved
pkg/notifier/sink.go Outdated Show resolved Hide resolved
internal/health/health.go Show resolved Hide resolved
internal/health/health.go Outdated Show resolved Hide resolved
internal/health/health.go Outdated Show resolved Hide resolved
internal/health/health.go Outdated Show resolved Hide resolved
internal/health/health.go Outdated Show resolved Hide resolved
internal/health/health.go Show resolved Hide resolved
pkg/bot/slack_cloud.go Show resolved Hide resolved
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Please apply the two final comments before merging :)

internal/health/status.go Show resolved Hide resolved
cmd/botkube-agent/main.go Show resolved Hide resolved
@madebyrogal madebyrogal merged commit ec12320 into kubeshop:main Oct 6, 2023
15 checks passed
@madebyrogal madebyrogal deleted the healthz-improve-endpoint branch October 6, 2023 12:41
josefkarasek pushed a commit that referenced this pull request Oct 6, 2023
* decouple health package from main.go

* get plugins health
improve health package

* get bot status

* fix test
add method description

* fix lint

* fix tests

* add sink type platforms to status

* show plugin config name in healthz

* additional unhealthy condition

* fix CR

* add tests

* fix status in slack cloud

* fix CR
josefkarasek pushed a commit that referenced this pull request Oct 6, 2023
* decouple health package from main.go

authored-by: Tomasz Rogalski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants