Fix Cloud Slack Dev E2E test after recent changes #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
fix-cloud-slack-tests
branch
from
d703b76
to
29bec08
Compare
pkosiec
force-pushed
the
fix-cloud-slack-tests
branch
from
c6f7218
to
d05de95
Compare
pkosiec
changed the title
pkosiec
changed the title
pkosiec
commented
Sep 28, 2023
pkosiec
changed the title
mszostok
approved these changes
Sep 29, 2023
| @@ -88,6 +88,8 @@ func TestCloudSlackE2E(t *testing.T) { | |||
| err := envconfig.Init(&cfg) | |||
| require.NoError(t, err) | |||
|
|
|||
| cfg.Slack.Tester.CloudBasedTestEnabled = false // override property used only in the Cloud Slack E2E tests | |||
There was a problem hiding this comment.
it would be good to differentiate a bit more it as we now have two things named cloud slack e2e tests, maybe sth like:
- cloud Slack enablement tests
- cloud Slack conversation tests
but let's follow up on this in a separate PR once you will be back @pkosiec
Co-authored-by: Pawel Kosiec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Fix integration tests on mainTesting
CI proves it: