Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce italic description for Button Builder API #1450

Merged
merged 1 commit into from
May 27, 2024

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented May 27, 2024

Description

Changes proposed in this pull request:

  • Introduce italic description for Button Builder API

The new style is used for AI plugin footer formatting.

Testing

No need to test it.

Related issue(s)

https://github.com/kubeshop/botkube-cloud/issues/1060

@pkosiec pkosiec added the other Internal, no user-facing changes. label May 27, 2024
@pkosiec pkosiec requested a review from vaijab May 27, 2024 13:11
@pkosiec pkosiec marked this pull request as ready for review May 27, 2024 13:11
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners May 27, 2024 13:11
Copy link
Collaborator

@vaijab vaijab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other platforms don't support italic? Or is this for the open source slack integration?

@pkosiec
Copy link
Member Author

pkosiec commented May 27, 2024

@vaijab We support advanced formatting like that (description + inline button for Slack and Teams only.
Teams formatter is closed-source, and we use the italic desc + inline button only for the closed-source AI plugin.
image

So yeah, the new helper function is used only for AI plugin for now 👍

@pkosiec pkosiec merged commit a3f727e into kubeshop:main May 27, 2024
18 of 20 checks passed
@pkosiec pkosiec deleted the update-formatter branch May 27, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Internal, no user-facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants