Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slack API dependency and remove workaround for stripping event details from logs #610

Merged
merged 1 commit into from
Jun 6, 2022
Merged

Update Slack API dependency and remove workaround for stripping event details from logs #610

merged 1 commit into from
Jun 6, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jun 6, 2022 •
edited
Loading

ISSUE TYPE
  • Feature Pull Request
  • Bug fix Pull Request
  • Docs Pull Request
SUMMARY

⚠️ NOTE: For convienence, this PR depends on #603 and needs to be rebased when #603 is merged (it should happen very soon). Actual changes: a6d91f2

As the upstream fix has been merged (slack-go/slack#1067), this PR updates slack-go/slack dependency and removes no longer needed workaround.

See the original issue: #579
See the PR that introduced the workaround: #583

TESTING

NOTE: You can also use pkosiec/botkube:rm-slack-workaround Docker image for testing. The image was repushed after rebase.

  1. Checkout this PR
  2. Edit comm_config.yaml and enable Slack
  3. Export needed envs:
export KUBECONFIG=/Users/$USER/.kube/config
export LOG_LEVEL=info
  1. Run BotKube locally:
go run ./cmd/botkube/main.go
  1. Start Slack huddle and say something, then leave
  2. Observe logs still without event details

@pkosiec pkosiec added enhancement New feature or request hold-off-merging labels Jun 6, 2022
@mszostok mszostok self-assigned this Jun 6, 2022
mszostok
mszostok approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works as expected 👍

@mergify mergify bot merged commit cced2fc into kubeshop:develop Jun 6, 2022
@mszostok mszostok mentioned this pull request Jun 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

Assignees

@mszostok mszostok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mszostok