Decrease the unmarshall error severity from err to warn #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR only decreases the unmarshall error severity from err to warn. To make it a bit better, we can contribute to the
slack
lib and replace:(source)
with error type
UnmappedError
. This won't be a breaking change for them, so we should be able to merge that.As a result, we will know the details about the error and could implement sth like:
In that way even if someone will configure custom Slack bot with wrong event subscription we will be able to “ignore them”.
WDYT? Is it worth it? If we stay with RTM, then it's the only option.
FINDINGS
I wanted to describe the workaround for this issue by creating the own Bot. I found that the current Bot is based on RTM. This means that it issues the old API.
In this case, we are not able to:
The best option would be changing the implementation from RTM to WebSocket mode. Should I create an issue?
Fixes #619