Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use image registry when building single Docker image #720

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Use image registry when building single Docker image #720

merged 1 commit into from
Sep 5, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Sep 5, 2022

Description

Changes proposed in this pull request:

  • Fix build single image target

As @madebyrogal noticed, our contribution guide says:

       ```sh
        IMAGE_PLATFORM=linux/arm64 make container-image-single
        docker tag ghcr.io/kubeshop/botkube:v9.99.9-dev <your_account>/botkube:v9.99.9-dev
        docker push <your_account>/botkube:v9.99.9-dev
        ```

And our container-image-single target produces kubeshop/botkube:v9.99.9-dev image. This PR fixes it.

@pkosiec pkosiec added the bug Something isn't working label Sep 5, 2022
@pkosiec pkosiec added this to the v0.14.0 milestone Sep 5, 2022
@madebyrogal
Copy link
Contributor

I've tested it. Works fine.

@pkosiec pkosiec merged commit 1801838 into kubeshop:main Sep 5, 2022
@pkosiec pkosiec deleted the fix-build-image-single branch September 5, 2022 12:50
@mszostok mszostok mentioned this pull request Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@madebyrogal madebyrogal madebyrogal approved these changes

@ezodude ezodude Awaiting requested review from ezodude

@huseyinbabal huseyinbabal Awaiting requested review from huseyinbabal

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pkosiec @madebyrogal @mszostok