Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define different k8s source presets, add option to set event list globally #739

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Define different k8s source presets, add option to set event list globally #739

merged 2 commits into from
Sep 21, 2022

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Sep 19, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add option to set events list globally
  • Define different k8s source presets
    • k8s-recommendation-events - enables all possible k8s recommendations
    • k8s-all-events - is the name of the previous configuration
    • k8s-err-events - enables only error events for resources that were watched previously

Related issue(s)

@mszostok mszostok added the enhancement New feature or request label Sep 19, 2022
@mszostok mszostok changed the title Add option to set event list globally Define different k8s source presets, add option to set event list globally Sep 20, 2022
@mszostok mszostok marked this pull request as ready for review September 20, 2022 09:27
@mszostok mszostok requested review from a team and PrasadG193 as code owners September 20, 2022 09:27
@mszostok mszostok added wip and removed wip labels Sep 20, 2022
@pkosiec pkosiec self-assigned this Sep 21, 2022
pkosiec
pkosiec approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please apply your suggestion and also see my question 🙂

Disclaimer: Didn't test it, as tests cover that functionality. Will test the whole notification presets functionality E2E

pkg/config/testdata/TestLoadConfigSuccess/config.golden.yaml Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) September 21, 2022 08:40
@mszostok mszostok merged commit c3ab05a into kubeshop:main Sep 21, 2022
@mszostok mszostok deleted the notification-presets branch September 23, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec