Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feedback cmd #743

Merged
merged 7 commits into from
Sep 21, 2022
Merged

Add feedback cmd #743

merged 7 commits into from
Sep 21, 2022

Conversation

madebyrogal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add feedback command
  • Add feedback command to help message

Related issue(s)

@madebyrogal madebyrogal requested review from a team and PrasadG193 as code owners September 20, 2022 10:24
@madebyrogal madebyrogal requested review from mszostok and removed request for huseyinbabal September 20, 2022 11:04
@mszostok mszostok self-assigned this Sep 21, 2022
@mszostok mszostok added the enhancement New feature or request label Sep 21, 2022
mszostok
mszostok reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three small comments, besides that, LGTM 🚀

pkg/bot/interactive/feedback.go Outdated Show resolved Hide resolved
pkg/bot/interactive/help.go Outdated Show resolved Hide resolved
mszostok
mszostok reviewed Sep 21, 2022
View reviewed changes
pkg/bot/slack.go Outdated Show resolved Hide resolved
mszostok
mszostok approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mszostok mszostok enabled auto-merge (squash) September 21, 2022 18:05
@mszostok mszostok enabled auto-merge (squash) September 21, 2022 18:07
@mszostok mszostok merged commit 11b5bc5 into kubeshop:main Sep 21, 2022
@madebyrogal madebyrogal deleted the feedback-cmd branch September 20, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@mszostok mszostok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madebyrogal @mszostok