-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Automation #751
Release Automation #751
Conversation
I addressed all the items, now;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left additional comments, I will test that now on my fork now 👍
Thanks, addressed them all, triggering jobs on my end too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to do the patch release 😞
EDIT: my fault.
@mszostok addressed the items we discussed today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my flow:
- Cut v0.55.0
- we have
v0.55.0-rc.1
✅
- we have
- Introduce new change
- we have
v0.55.0-rc.2
✅
- we have
- Click finalize release
- we have
v.0.52.0
✅
- we have
All Helm charts looks good (image updated). Docker images are present in my ghcr.io
- Merge PR with patch to relaase-0.55
- cutting next RC failed ❌ but there was a helpful message about cutting a dedicated patch release
- I cut the release for v0.55.1
- we have
v0.55.1-rc.1
✅
- we have
- Click finalize release
- we have
v.0.55.1
❓ ✅ - but the job failed on pushing the tag https://github.com/mszostok/botkube/actions/runs/3141812407/jobs/5104685078
- however the release was triggered properly: https://github.com/mszostok/botkube/actions/runs/3141817743
- we have
All Helm charts looks good (image updated). Docker images are present in my ghcr.io
LGTM 👍 a really nice job!
Before merging, please see my last comments:
- I saw that perms has changed for
hack/process-chart.sh
, any reason for that? - why we have failed job for cutting the patch release: https://github.com/mszostok/botkube/actions/runs/3141812407/jobs/5104685078
fatal: tag 'v0.55.1' already exists
. From my investigation, is a problem withprocess-chart
which doesn't supportskip-tagging
properly.- related: Release Automation #751 (comment)
- Release Automation #751 (comment)
Description
Changes proposed in this pull request:
Cut a new release
andFinalize Release
. Cut a new release is used once we decide to cut-off the main or release branch for a specific milestone. Finalize release is used to mark the release as stable once we verify everything in prerelease.Code Freeze
Next Release Candidate
Once the release branch is pushed, it triggers a subsequent release candidate preparation that contains;
For example, once Helm charts are processed, changes are automatically pushed to the release branch. Here is some view of those.
Finalize Release
Once we verify everything in prereleases, we can just finalize the release.
Related issue(s)
Fixes #584
Documentation