Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove installation ID generation for anonymous analytics #759

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Sep 23, 2022

Description

Changes proposed in this pull request:

  • Remove installation ID generation for anonymous analytics

We don't need that actually, we'll use kube-system UID as the anonymous ID.

Testing

 export ANALYTICS_API_KEY=""
go build -ldflags="-X github.com/kubeshop/botkube/internal/analytics.APIKey=${ANALYTICS_API_KEY}" -o ./botkube ./cmd/botkube/main.go
# command-line-arguments
export BOTKUBE_SETTINGS_LOG_LEVEL=info
export BOTKUBE_SETTINGS_KUBECONFIG=/Users/$USER/.kube/config
export BOTKUBE_CONFIG_PATHS="$(pwd)/resource_config.yaml,$(pwd)/comm_config.yaml"
./botkube

See the Identify event inside Segment debugger (contact me to have access).

Related issue(s)

Resolves #753
Resolves #729

@pkosiec pkosiec added the bug Something isn't working label Sep 23, 2022
@pkosiec pkosiec added this to the v0.14.0 milestone Sep 23, 2022
@pkosiec pkosiec force-pushed the fix-telemetry-upgrade branch 2 times, most recently from f2e530a to 9d8adf4 Compare September 23, 2022 12:37
@pkosiec pkosiec changed the title Fix analytics parameter override during Helm chart upgrade Remove installation ID generation for anonymous analytics Sep 23, 2022
@pkosiec pkosiec marked this pull request as ready for review September 23, 2022 13:02
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners September 23, 2022 13:02
@mszostok mszostok self-assigned this Sep 23, 2022
@pkosiec pkosiec force-pushed the fix-telemetry-upgrade branch 2 times, most recently from 2378000 to 87c9e5a Compare September 23, 2022 14:25
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code point of view, LGTM 👍
I will ping you about e2e tests later today 👍

@pkosiec pkosiec merged commit 78210ef into kubeshop:main Sep 27, 2022
@pkosiec pkosiec deleted the fix-telemetry-upgrade branch September 27, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants