Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message in help, and ignore modal activity #761

Merged
merged 5 commits into from
Sep 27, 2022

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Sep 26, 2022

Description

Changes proposed in this pull request:

  • Update message in help
  • Ignore modal activity
  • Address feedback after demo (ffdf70b):
    • change docs URL from https://botkube.io/ to https://botkube.io/docs
    • change message from The foo source was not found. to The foo source was not found. To learn how to add custom source, visit https://botkube.io/docs/configuration/source.
    • humanize command list to "Available kubectl commands"

Related issue(s)

Fix #710
Fix #683

@mszostok mszostok added the bug Something isn't working label Sep 26, 2022
@mszostok mszostok requested review from a team and PrasadG193 as code owners September 26, 2022 12:49
@mszostok mszostok requested review from huseyinbabal and pkosiec and removed request for huseyinbabal September 26, 2022 12:49
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/execute/edit.go Show resolved Hide resolved
@mszostok mszostok merged commit b100713 into kubeshop:main Sep 27, 2022
@mszostok mszostok deleted the update-slack-impl branch September 27, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Presets Show interactive help command to the user
2 participants