Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service to the default executor configuration, remove problematic emoji #780

Merged
merged 2 commits into from
Oct 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/botkube/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Controller for the BotKube Slack app which helps you monitor your Kubernetes clu
| [executors.kubectl-read-only.kubectl.namespaces.exclude](./values.yaml#L254) | list | `[]` | List of ignored Kubernetes Namespace. It can also contain a regex expressions: `- "test-.*"` - to specify all Namespaces. |
| [executors.kubectl-read-only.kubectl.enabled](./values.yaml#L256) | bool | `false` | If true, enables `kubectl` commands execution. |
| [executors.kubectl-read-only.kubectl.commands.verbs](./values.yaml#L260) | list | `["api-resources","api-versions","cluster-info","describe","diff","explain","get","logs","top","auth"]` | Configures which `kubectl` methods are allowed. |
| [executors.kubectl-read-only.kubectl.commands.resources](./values.yaml#L262) | list | `["deployments","pods","namespaces","daemonsets","statefulsets","storageclasses","nodes","configmaps"]` | Configures which K8s resource are allowed. |
| [executors.kubectl-read-only.kubectl.commands.resources](./values.yaml#L262) | list | `["deployments","pods","namespaces","daemonsets","statefulsets","storageclasses","nodes","configmaps","services"]` | Configures which K8s resource are allowed. |
| [executors.kubectl-read-only.kubectl.defaultNamespace](./values.yaml#L264) | string | `"default"` | Configures the default Namespace for executing BotKube `kubectl` commands. If not set, uses the 'default'. |
| [executors.kubectl-read-only.kubectl.restrictAccess](./values.yaml#L266) | bool | `false` | If true, enables commands execution from configured channel only. |
| [existingCommunicationsSecretName](./values.yaml#L277) | string | `""` | Configures existing Secret with communication settings. It MUST be in the `botkube` Namespace. To reload BotKube once it changes, add label `botkube.io/config-watch: "true"`. |
Expand Down
2 changes: 1 addition & 1 deletion helm/botkube/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ executors:
# -- Configures which `kubectl` methods are allowed.
verbs: ["api-resources", "api-versions", "cluster-info", "describe", "diff", "explain", "get", "logs", "top", "auth"]
# -- Configures which K8s resource are allowed.
resources: ["deployments", "pods", "namespaces", "daemonsets", "statefulsets", "storageclasses", "nodes", "configmaps"]
resources: ["deployments", "pods", "namespaces", "daemonsets", "statefulsets", "storageclasses", "nodes", "configmaps", "services"]
# -- Configures the default Namespace for executing BotKube `kubectl` commands. If not set, uses the 'default'.
defaultNamespace: default
# -- If true, enables commands execution from configured channel only.
Expand Down
1 change: 0 additions & 1 deletion pkg/bot/teams.go
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,5 @@ var emojiMapping = map[string]string{
":rocket:": "🚀",
":white_check_mark:": "✅",
":arrows_counterclockwise:": "🔄",
":crossed_fingers:": "🤞",
":exclamation:": "❗",
}
2 changes: 1 addition & 1 deletion pkg/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (

const (
controllerStartMsg = "My watch begins for cluster '%s'! :crossed_swords:"
controllerStopMsg = "My watch has ended for cluster '%s'. See you soon! :crossed_fingers:"
controllerStopMsg = "My watch has ended for cluster '%s'. See you soon!"

finalMessageTimeout = 20 * time.Second
)
Expand Down
1 change: 1 addition & 0 deletions test/e2e/bots_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ func runBotTest(t *testing.T,
- storageclasses
- nodes
- configmaps
- services
defaultNamespace: default
restrictAccess: false
kubectl-wait-cmd:
Expand Down