Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support quotes for the --cluster-name flag #800

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Support quotes for the --cluster-name flag #800

merged 1 commit into from
Oct 7, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Oct 7, 2022

Description

Changes proposed in this pull request:

  • Support quotes for the --cluster-name flag
  • Suggest in help providing cluster name without quotes (as they might be problematic in some communication platforms - e.g. replaced with different characters)

Screenshots

Screenshot 2022-10-07 at 14 05 10

image

Related issue(s)

Resolves #799

@pkosiec pkosiec added the bug Something isn't working label Oct 7, 2022
@pkosiec pkosiec added this to the v0.15.0 milestone Oct 7, 2022
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners October 7, 2022 12:06
@pkosiec pkosiec requested a review from ezodude October 7, 2022 12:06
ezodude
ezodude approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@ezodude ezodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkg/utils/utils.go Show resolved Hide resolved
@pkosiec pkosiec enabled auto-merge (squash) October 7, 2022 12:36
auto-merge was automatically disabled October 7, 2022 13:00

Base branch was modified

@pkosiec pkosiec enabled auto-merge (squash) October 7, 2022 13:14
@pkosiec pkosiec disabled auto-merge October 7, 2022 13:14
@pkosiec pkosiec merged commit 92c55b2 into kubeshop:main Oct 7, 2022
@pkosiec pkosiec deleted the fix-multicluster-cmd branch October 7, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezodude ezodude ezodude approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Using --cluster-name stops any responses
2 participants
@pkosiec @ezodude