Output filtering

[ezodude]

Description

Changes proposed in this pull request:

• Enables output filtering of executor based commands with a text output.

Analytics Reporting

ReportCommand(platform config.CommPlatformIntegration, command string, isButtonClickOrigin, withFilter bool) error has been extended to include withFilter to indicate whether a filter was used when running the command.

Testing

Install BotKube:

cat > /tmp/results-filter.yaml << ENDOFFILE
executors:
  'kubectl-enabled':
    kubectl:
      namespaces:
        include:
          - ".*"
        exclude: []
      enabled: true
      commands:
        verbs: ["api-resources", "api-versions", "cluster-info", "describe", "explain", "get", "logs", "top"]
        resources: ["deployments", "pods", "namespaces", "daemonsets", "statefulsets", "storageclasses", "nodes", "configmaps", "services"]
      defaultNamespace: default
      restrictAccess: false

communications:
  'default-group':
    socketSlack:
      enabled: true
      channels:
        'default':
          name: 'random'
          bindings:
            executors:
              - kubectl-enabled
            sources:
              - k8s-err-events
              - k8s-recommendation-events
      botToken: 'xoxb-...'
      appToken: 'xapp-...'
      notification:
        type: short

settings:
  clusterName: kind

  log:
    level: debug
    disableColors: false

analytics:
  disable: true

image:
  repository: kubeshop/pr/botkube
  tag: '808-PR'
  pullPolicy: Always  
ENDOFFILE

helm install botkube ./helm/botkube -n botkube --create-namespace /tmp/results-filter.yaml

Run commands on botkube-test channel on Slack:

@BotKube get po -n kube-system --filter="proxy"

@Botkube commands list --filter=“api”

@BotKube get po -n kube-system --filter=proxy

@BotKube get po --filter="proxy" -n kube-system

@BotKube logs pods/kube-proxy-9qzj2 -n kube-system --filter="Detected node"

Related issue(s)

Resolves #742

[mszostok]

Please add proper labels to this PR. Thanks!

[ezodude]

@mszostok rebased from master and ready - that was painful!

The executor was changed a lot while I was also working on it.

[mszostok]

From the unit-test point of view, the behavior LGTM 👍
However, e2e it doesn't work yet, but as discussed I will go back to testing once you will do the final round of rebasing and rechecking 👍

[ezodude]

• Updates to ensure command names are visible for commands like ping.
• E2E tests are now fixed.

[mszostok]

I found one more panic, but besides that it LGTM 👍