Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CONTRIBUTING.md file is outdated #809

Merged
merged 16 commits into from
Oct 18, 2022
Merged

The CONTRIBUTING.md file is outdated #809

merged 16 commits into from
Oct 18, 2022

Conversation

ezodude
Copy link
Contributor

@ezodude ezodude commented Oct 12, 2022

Description

Changes proposed in this pull request:

  • Updated Botkube helm installation instructions for contributors.
  • Linked to docs as reference installation instructions when encountering problems.
  • Added a new step to ensure a Slack integration is already setup.
  • General tidy up.

Related issue(s)

Resolves #804

@ezodude ezodude requested review from a team and PrasadG193 as code owners October 12, 2022 09:21
@ezodude ezodude requested a review from pkosiec October 12, 2022 09:21
@pkosiec pkosiec self-assigned this Oct 12, 2022
@pkosiec pkosiec added documentation Documetation is missing or incorrect community labels Oct 12, 2022
pkosiec
pkosiec reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, 2 small comments 🙂

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@ezodude ezodude requested a review from pkosiec October 17, 2022 15:27
pkosiec
pkosiec reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor comments with suggestions ready to add to batch & commit from the GitHub UI, as long as you agree with them 🙂 That should be really quick - let me know when it's ready to approve ✅

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
test/README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
ezodude and others added 10 commits October 18, 2022 08:08
@ezodude @pkosiec
Update CONTRIBUTING.md
7d6689b 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update CONTRIBUTING.md
72568f5 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update test/README.md
38d2cd1 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update test/README.md
68a5d24 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update CONTRIBUTING.md
1a46b89 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update CONTRIBUTING.md
ad70c9b 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update CONTRIBUTING.md
e71154a 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update CONTRIBUTING.md
2191f69 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude @pkosiec
Update CONTRIBUTING.md
02aeb17 
Co-authored-by: Pawel Kosiec <[email protected]>
@ezodude
Minor tidy up.
53c40d0
@ezodude ezodude requested a review from pkosiec October 18, 2022 07:14
@ezodude
Copy link
Contributor Author

ezodude commented Oct 18, 2022

Done.

pkosiec
pkosiec approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ezodude ezodude merged commit 32ff214 into kubeshop:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
community documentation Documetation is missing or incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The CONTRIBUTING.md file is outdated
2 participants
@ezodude @pkosiec