Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opt to append filter when building the kubectl command #812

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Add opt to append filter when building the kubectl command #812

merged 3 commits into from
Oct 14, 2022

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Oct 13, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add opt to append filter when building the kubectl command
  • Reduce the Slack message size

Demo

Screen.Recording.2022-10-13.at.13.53.50.mov

Related issue(s)

#748

@mszostok mszostok added enhancement New feature or request slack labels Oct 13, 2022
@mszostok mszostok requested review from a team and PrasadG193 as code owners October 13, 2022 11:37
@mszostok mszostok requested a review from ezodude October 13, 2022 11:37
@mszostok mszostok mentioned this pull request Oct 13, 2022
Closed
@mszostok
Copy link
Contributor Author

The filter option was updated according to the Lacho feedback:

  • render it under the command preview (above the "run" button)
  • render it only if preview is visible

New look and feel:
Screen Shot 2022-10-13 at 14 45 31

ezodude
ezodude approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@ezodude ezodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested locally.

Left non blocker comment.

pkg/bot/interactive/message.go Outdated Show resolved Hide resolved
pkg/bot/interactive/message.go Outdated Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) October 14, 2022 10:51
@mszostok mszostok enabled auto-merge (squash) October 14, 2022 11:18
@mszostok mszostok merged commit fe9148c into kubeshop:main Oct 14, 2022
@mszostok mszostok deleted the kc-builder/filter-flag branch October 14, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezodude ezodude ezodude approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @ezodude