Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use real command guard and cached client, fix bug with orphan resource name #818

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Use real command guard and cached client, fix bug with orphan resource name #818

merged 3 commits into from
Oct 17, 2022

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Oct 17, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

Related issue(s)

#748

@mszostok mszostok added the enhancement New feature or request label Oct 17, 2022
@mszostok mszostok requested review from a team and PrasadG193 as code owners October 17, 2022 12:04
@mszostok mszostok requested a review from pkosiec October 17, 2022 12:04
@mszostok mszostok mentioned this pull request Oct 17, 2022
Closed
@mszostok mszostok added the wip label Oct 17, 2022
@mszostok mszostok removed the wip label Oct 17, 2022
pkosiec
pkosiec approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally works well 👍 But please see my 2 comments before merge. Thanks!

pkg/execute/kubectl/guard.go Show resolved Hide resolved
@mszostok mszostok enabled auto-merge (squash) October 17, 2022 13:32
@mszostok mszostok merged commit 2cb65d1 into kubeshop:main Oct 17, 2022
@mszostok mszostok deleted the kc-builder/guard-ns-bug branch October 17, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec