Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start|stop -> enable|disable notifications #924

Merged
merged 4 commits into from
Jan 10, 2023
Merged

start|stop -> enable|disable notifications #924

merged 4 commits into from
Jan 10, 2023

Conversation

josefkarasek
Copy link

Description

Last occurrence of old start|stop notifications

@josefkarasek josefkarasek requested a review from a team as a code owner January 9, 2023 09:40
@josefkarasek josefkarasek self-assigned this Jan 9, 2023
@josefkarasek josefkarasek added the bug Something isn't working label Jan 9, 2023
mszostok
mszostok approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josefkarasek josefkarasek merged commit a5376b4 into kubeshop:main Jan 10, 2023
@josefkarasek josefkarasek deleted the fix-cmd branch January 10, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@josefkarasek josefkarasek

Labels
bug Something isn't working
Projects
Botkube
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josefkarasek @mszostok