Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changelog generation #928

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix changelog generation #928

merged 1 commit into from
Jan 10, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jan 9, 2023

Description

Changes proposed in this pull request:

  • Fix changelog generation

Testing

Local run:

gh api repos/kubeshop/botkube/releases/generate-notes \
    -f tag_name="v0.17.0" \
    -f previous_tag_name="v0.16.0" \
    -q .body > CHANGELOG.md

generates a valid changelog. When the previous_tag_name is not specified, the auto is used, and it doesn't work well in our scenario.

@mszostok mszostok added the bug Something isn't working label Jan 9, 2023
@mszostok mszostok requested review from a team and PrasadG193 as code owners January 9, 2023 13:36
josefkarasek
josefkarasek approved these changes Jan 10, 2023
View reviewed changes
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josefkarasek josefkarasek merged commit 072b97b into kubeshop:main Jan 10, 2023
@mszostok mszostok deleted the fix-release branch January 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefkarasek josefkarasek josefkarasek approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @josefkarasek