helm option is added for config source #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
reviewed
Jan 12, 2023
helm/botkube/values.yaml
Outdated
Comment on lines
878
to
879
| # -- Base source definition | ||
| source: |
There was a problem hiding this comment.
Can we change that to provider as Mateusz suggested?
Suggested change
| # -- Base source definition | |
| source: | |
| # -- Configuration provider details | |
| provider: |
Comment on lines
117
to
121
| - name: CONFIG_SOURCE_ENDPOINT | ||
| value: {{ .Values.config.source.endpoint }} | ||
| {{- end }} | ||
| {{- if .Values.config.source.identifier }} | ||
| - name: CONFIG_SOURCE_IDENTIFIER |
There was a problem hiding this comment.
Once we change values, can we also rename these envs to CONFIG_PROVIDER_ENDPOINT and CONFIG_PROVIDER_IDENTIFIER?
|
Updated both helm values and botkube core, as well as screenshots with pr descriptions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
config.provider.endpointhelm option is addedconfig.provider.identifierhelm option is addedTesting
With config source
helm install --version v0.17.0 botkube --namespace botkube --create-namespace \ --set settings.clusterName=dev \ --set executors.kubectl-read-only.kubectl.enabled=true \ --set 'executors.helm.botkube/helm.enabled'=false \ --set config.provider.identifier=12123 \ --set config.provider.endpoint=http://localhost:8080/graphql \ ./helm/botkubeWithout config source
helm install --version v0.17.0 botkube --namespace botkube --create-namespace \ --set settings.clusterName=dev \ --set executors.kubectl-read-only.kubectl.enabled=true \ --set 'executors.helm.botkube/helm.enabled'=false \ ./helm/botkubeRelated issue(s)
Resolves #931