Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch only used plugin repositories, fix logging, add repo validation #940

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fetch only used plugin repositories, fix logging, add repo validation #940

merged 1 commit into from
Jan 13, 2023

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Jan 13, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fetch only used plugin repositories,
  • Fix logging messages,
  • Add repo validation, so user gets more useful error message
    • without that you only get not found source plugin called "cm-test" in "botkube" repository. And it's misleading as it suggests that the botkube repository was found. Now, as the repositories are validated, this error message is valid.

Related issue(s)

Fix #939

@mszostok mszostok added the enhancement New feature or request label Jan 13, 2023
@mszostok mszostok requested review from a team and PrasadG193 as code owners January 13, 2023 13:18
@mszostok mszostok requested a review from pkosiec January 13, 2023 13:18
pkosiec
pkosiec approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

internal/source/dispatcher.go Show resolved Hide resolved
@mszostok mszostok merged commit 28ba826 into kubeshop:main Jan 13, 2023
@mszostok mszostok deleted the fix-manager branch January 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugins log typo
2 participants
@mszostok @pkosiec