Fix Prometheus source JSON schema and generated resources CI job #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
fix-prometheus-schema
branch
2 times, most recently
from
4e88902
to
f628d10
Compare
pkosiec
force-pushed
the
fix-prometheus-schema
branch
from
f628d10
to
4abb4be
Compare
|
I'm not sure why I'm getting error https://github.com/kubeshop/botkube/actions/runs/3997391552/jobs/6858659306 if I already updated the files. And why I didn't get such error earlier when I updated gRPC API? Is it because this is Oh right... check-generated-resources:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
fetch-depth: 0Will fix that here as well. |
pkosiec
requested review from
josefkarasek and
mszostok
and removed request for
josefkarasek
mszostok
approved these changes
Jan 25, 2023
pkosiec
changed the title
mszostok
pushed a commit
to mszostok/botkube
that referenced
this pull request
Jan 25, 2023
…eshop#952) * Fix Prometheus source JSON schema * Fix `check-generated-resources` job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
check-generated-resourcesjob. Changes will be applied after merge.Testing
Checkout this PR and run:
PLUGIN_DOWNLOAD_URL_BASE_PATH="http://localhost:8080/plugin-dist" make gen-plugins-indexThen verify the output index file to see if the schema is valid. You can use https://www.jsonschemavalidator.net/ to validate both previous and current (from this PR) schemas.