-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support global aliases for commands #956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
force-pushed
the
executor-aliases
branch
4 times, most recently
from
January 30, 2023 16:34
4c99f74
to
8743452
Compare
pkosiec
force-pushed
the
executor-aliases
branch
from
January 31, 2023 13:08
6f90398
to
6825658
Compare
josefkarasek
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGMT. With minor nits.
pkg/config/testdata/TestLoadedConfigValidationErrors/invalid-alias.yaml
Outdated
Show resolved
Hide resolved
pkosiec
force-pushed
the
executor-aliases
branch
from
January 31, 2023 16:08
f07b9c7
to
b9fda3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
@Botkube list aliases
command@Botkube list executors
to include aliases for executors@Botkube list sources
commandTODO
botkube-docs
.Screenshots
Help
List executors
List sources
Executing commands
List aliases
Filtering
Testing
Check out the PR
Use the following config:
Run a few commands:
@Botkube kgp -n botkube
@Botkube h version
@Botkube k get po
Run
@Botkube list aliases
Run
@Botkube list executors
Related issue(s)
#870