Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment deprecated Slack configuration properties #962

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Feb 1, 2023

Description

Changes proposed in this pull request:

  • Comment deprecated Slack properties in Helm chart and code

While we still use deprecated Slack integration for tests (until #865 is done), we should explicitly mention to avoid using the deprecated property. This PR adds proper comments to encourage switching to the new integration.

Related issue(s)

See also #865

@pkosiec pkosiec added the bug Something isn't working label Feb 1, 2023
@pkosiec pkosiec added this to the v0.18.0 milestone Feb 1, 2023
@pkosiec pkosiec marked this pull request as ready for review February 1, 2023 12:40
@pkosiec pkosiec requested review from a team and PrasadG193 as code owners February 1, 2023 12:40
@pkosiec pkosiec merged commit a252a6c into kubeshop:main Feb 2, 2023
@pkosiec pkosiec deleted the comment-legacy-slack-opts branch February 2, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants