-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive builder in kubectl plugin #982
Add interactive builder in kubectl plugin #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! Awesome work 🥳
Just a few comments with open questions / small improvement requests.
Also see the review for the docs: kubeshop/botkube-docs#213
e3de9bc
to
71be7c2
Compare
71be7c2
to
cd80788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
(Disclaimer: didn't test it after resolving review commens, but the changes weren't invasive so 🤞 Let me know if I should double check it still works 😄)
Description
The builder is based on the existing code base but with adjustments like:
If you have IntelliJ, just select
kubectl_test.go
andkubectl_cmd_builder_test.go
files and click "Compare Files" (cmd+d)kubectl.go
andkubectl_cmd_builder.go
files and click "Compare Files" (cmd+d)Changes proposed in this pull request:
kubectl
builder verbs and resources dynamically #981Testing
make build-plugins-single
env PLUGIN_SERVER_HOST=http://host.k3d.internal go run test/helpers/plugin_server.go
k3d cluster create labs --image=rancher/k3s:v1.25.0-k3s1
export KUBECONFIG=/Users/$USER/.kube/config # set custom path if necessary
botkube/kubectl
plugin:interactiveBuilder
config.export KUBECONFIG=/tmp/devops-cluster-admin-config
and restart botkube.Screen.Recording.2023-02-15.at.12.42.26.mov
Related issue(s)