Merge pull request #259 from kubeshop/mm/fix/badassertionresults

fix: check trace object before run the test
kubeshop · Apr 20, 2022 · 2e70a3f · 2e70a3f
2 parents 77ab898 + b131bd2
commit 2e70a3f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/web/src/components/Trace/Trace.tsx b/web/src/components/Trace/Trace.tsx
@@ -1,6 +1,7 @@
 import styled from 'styled-components';
 import {useStoreActions} from 'react-flow-renderer';
 import {ReflexContainer, ReflexSplitter, ReflexElement} from 'react-reflex';
+import {isEmpty} from 'lodash';
 
 import {Button, Skeleton, Tabs} from 'antd';
 
@@ -78,7 +79,7 @@ const Trace: React.FC<TraceProps> = ({test, testResultId}) => {
   }, [refetchTrace]);
 
   useEffect(() => {
-    if (testResultDetails && !testResultDetails?.assertionResult) {
+    if (testResultDetails  && !isEmpty(testResultDetails.trace) && !testResultDetails?.assertionResult) {
       const resultList = runTest(testResultDetails.trace, test);
 
       setTraceResultList(resultList);
@@ -88,15 +89,15 @@ const Trace: React.FC<TraceProps> = ({test, testResultId}) => {
         resultId: testResultId,
         assertionResult: parseAssertionResultListToTestResult(resultList),
       });
-    } else if (testResultDetails?.assertionResult) {
+    } else if (testResultDetails?.assertionResult && !isEmpty(testResultDetails?.trace)) {
       setTraceResultList(
         parseTestResultToAssertionResultList(testResultDetails?.assertionResult, test, testResultDetails?.trace)
       );
     }
   }, [testResultDetails, test, testResultId, updateTestResult]);
 
   useEffect(() => {
-    if (testResultDetails) {
+    if (testResultDetails && !isEmpty(testResultDetails.trace)) {
       const resultList = runTest(testResultDetails.trace, test);
 
       setTraceResultList(resultList);