Adding safe method to get SpanID on assertion (#2313)

kubeshop · Apr 5, 2023 · 8c056d8 · 8c056d8
1 parent 125db30
commit 8c056d8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/server/executor/assertion_runner.go b/server/executor/assertion_runner.go
@@ -191,7 +191,7 @@ func (e *defaultAssertionRunner) emitFailedAssertions(ctx context.Context, req A
 						req.Run.TestID,
 						req.Run.ID,
 						unwrappedError,
-						spanAssertionResult.SpanID.String(),
+						spanAssertionResult.SafeSpanIDString(),
 						string(assertionResult.Assertion),
 					))
 				}
@@ -201,7 +201,7 @@ func (e *defaultAssertionRunner) emitFailedAssertions(ctx context.Context, req A
 						req.Run.TestID,
 						req.Run.ID,
 						spanAssertionResult.CompareErr,
-						spanAssertionResult.SpanID.String(),
+						spanAssertionResult.SafeSpanIDString(),
 						string(assertionResult.Assertion),
 					))
 				}

diff --git a/server/model/tests.go b/server/model/tests.go
@@ -137,6 +137,14 @@ type (
 	}
 )
 
+func (sar SpanAssertionResult) SafeSpanIDString() string {
+	if sar.SpanID == nil {
+		return ""
+	}
+
+	return sar.SpanID.String()
+}
+
 func (t Test) HasID() bool {
 	return t.ID != ""
 }