fix(frontend): fix test run success message (#2514)

kubeshop · May 12, 2023 · d1c50f1 · d1c50f1
1 parent bf6cf53
commit d1c50f1
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/web/src/components/RunDetailLayout/RunDetailLayout.tsx b/web/src/components/RunDetailLayout/RunDetailLayout.tsx
@@ -4,12 +4,15 @@ import {useParams} from 'react-router-dom';
 import RunDetailTest from 'components/RunDetailTest';
 import RunDetailTrace from 'components/RunDetailTrace';
 import RunDetailTrigger from 'components/RunDetailTrigger';
-import {RunDetailModes, TestState} from 'constants/TestRun.constants';
-import TestRunAnalyticsService from 'services/Analytics/TestRunAnalytics.service';
-import {useTestRun} from 'providers/TestRun/TestRun.provider';
+import {RunDetailModes} from 'constants/TestRun.constants';
 import useDocumentTitle from 'hooks/useDocumentTitle';
 import Test from 'models/Test.model';
+import {isRunStateSucceeded} from 'models/TestRun.model';
 import {useNotification} from 'providers/Notification/Notification.provider';
+import {useSettingsValues} from 'providers/SettingsValues/SettingsValues.provider';
+import {useTestRun} from 'providers/TestRun/TestRun.provider';
+import TestRunAnalyticsService from 'services/Analytics/TestRunAnalytics.service';
+import {ConfigMode} from 'types/DataStore.types';
 import HeaderLeft from './HeaderLeft';
 import HeaderRight from './HeaderRight';
 import * as S from './RunDetailLayout.styled';
@@ -34,19 +37,24 @@ const RunDetailLayout = ({test: {id, name, trigger, version = 1}, test}: IProps)
   const {mode = RunDetailModes.TRIGGER} = useParams();
   const {showNotification} = useNotification();
   const {isError, run, runEvents} = useTestRun();
+  const {dataStoreConfig} = useSettingsValues();
   const [prevState, setPrevState] = useState(run.state);
   useDocumentTitle(`${name} - ${run.state}`);
 
   useEffect(() => {
-    if (run.state === TestState.FINISHED && prevState !== TestState.FINISHED) {
+    const isNoTracingMode = dataStoreConfig.mode === ConfigMode.NO_TRACING_MODE;
+
+    if (isRunStateSucceeded(run.state) && !isRunStateSucceeded(prevState)) {
       showNotification({
         type: 'success',
-        title: 'Trace has been fetched successfully',
+        title: isNoTracingMode
+          ? 'Response received. Skipping looking for trace as you are in No-Tracing Mode'
+          : 'Trace has been fetched successfully',
       });
     }
 
     setPrevState(run.state);
-  }, [prevState, run.state, showNotification]);
+  }, [dataStoreConfig.mode, prevState, run.state, showNotification]);
 
   const tabBarExtraContent = useMemo(
     () => ({

diff --git a/web/src/components/TestSpecs/Empty.tsx b/web/src/components/TestSpecs/Empty.tsx
@@ -31,8 +31,9 @@ const Empty = () => {
       <S.EmptyTitle>There are no test specs for this test</S.EmptyTitle>
       <S.EmptyText>Add a test spec, or choose from our predefined test specs:</S.EmptyText>
       <S.SnippetsContainer>
-        {TEST_SPEC_SNIPPETS.map(snippet => (
-          <div>
+        {TEST_SPEC_SNIPPETS.map((snippet, index) => (
+          // eslint-disable-next-line react/no-array-index-key
+          <div key={`${snippet.selector}-${index}`}>
             <Button
               disabled={!isRunStateSucceeded(state)}
               icon={<AimOutlined />}