Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test snippets user can use #2174

Closed
olha23 opened this issue Mar 15, 2023 · 4 comments · Fixed by #2366
Closed

Add test snippets user can use #2174

olha23 opened this issue Mar 15, 2023 · 4 comments · Fixed by #2366

Comments

@olha23
Copy link

olha23 commented Mar 15, 2023

We need to add key assertions that provide value out-of-the-box.
Possible scenario:
Multiple of the examples Postman has would apply:
Response status code is 200
Response body contains string
Response body JSON value check
Response time is less than 200ms
but there are additional ones we could show:
all database spans return in less than 100ms
all http spans return status code of 200
all gRPC spans return status code of 0

@olha23 olha23 added the design label Mar 15, 2023
@olha23 olha23 self-assigned this Mar 15, 2023
@xoscar
Copy link
Collaborator

xoscar commented Mar 23, 2023

This is still future work, right? if there is anything we can do to speed this up let us know 😄

@olha23
Copy link
Author

olha23 commented Mar 23, 2023

@xoscar @jorgeepc need you feedback on this https://www.figma.com/file/LBN4SKVPq3ykegrPKbHT2Y/0.8-0.9-Release-Tracetest?node-id=2163%3A33256&t=P9kNAyXKV3bbliy7-1

@kdhamric
Copy link
Collaborator

Copying @xoscar questions from Figma here so we can discuss them:

Should the examples match the spans that exist in the trace? In the first iteration, lets just keep it simple and have a defined list and have all of them show.
Should we breakdown the examples by types? db/http/faas, etc? I don't think we need to
Should we have a list of examples by type documented somewhere? Perhaps, but I don't think we need to include that in this scope.

@xoscar
Copy link
Collaborator

xoscar commented Apr 11, 2023

@kdhamric

@xoscar xoscar self-assigned this Apr 11, 2023
@xoscar xoscar linked a pull request Apr 11, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants