feature(frontend): adding test spec snippets #2366
Conversation
|
|
||
| export type TSnippet = Required<IValues>; | ||
|
|
||
| export const HTTP_SPANS_STATUS_CODE: TSnippet = { |
There was a problem hiding this comment.
Here's where we can continue adding snippets, you can add it manually using the UI and then copy the details in this file @kdhamric
| ], | ||
| }; | ||
|
|
||
| export const TEST_SPEC_SNIPPETS: TSnippet[] = [ |
There was a problem hiding this comment.
Dont forget to add it to this array
| children: TEST_SPEC_SNIPPETS.map(snippet => ({ | ||
| label: snippet.name, | ||
| key: snippet.name, | ||
| onClick: () => onSnippetClick(snippet), | ||
| })), |
There was a problem hiding this comment.
I was thinking if we should include an option to create an empty test spec. I know you can click the left part of the button but maybe users won't get it.
There was a problem hiding this comment.
Would it behave differently than clicking the left button? I think we can gather some feedback on the current UX and then we can think of updating it.
We also need @kdhamric feedback on what other snippets he'd like to add
There was a problem hiding this comment.
It should have the same behavior as clicking the left button. It could be the last item in the list (with a visual separator).
There was a problem hiding this comment.
Creating a list now.
I am afraid many people will not find this list of available test specs. A cheesy, but possibly workable solution, would be to have the dropdown list 'open' by default Proposal: if you go to the Test screen and there are no Test Specs defined, the dropdown list is Open. @olha23 thoughts?
There was a problem hiding this comment.
Here are 3 more 'prompted test specs'
export const TRIGGER_SPAN_RESPONSE_BODY_CONTAINS: TSnippet = {
name: 'Trigger Span: Response body contains "this string"',
selector: 'span[tracetest.span.type="general" name="Tracetest trigger"]',
assertions: [
{
left: 'attr:tracetest.response.body',
comparator: 'contains',
right: '"this string"',
},
],
};
export const GRPC_SPANS_STATUS_CODE: TSnippet = {
name: 'All gRPC Spans: Status is Ok',
selector: 'span[tracetest.span.type="rpc" rpc.system="grpc"]',
assertions: [
{
left: 'attr:grpc.status_code',
comparator: '=',
right: '0',
},
],
};
export const DB_SPANS_QUALITY_DB_STATEMENT_PRESENT: TSnippet = {
name: 'All Database Spans: db.statement should always be defined (QUALITY)',
selector: 'span[tracetest.span.type="database"]',
assertions: [
{
left: 'attr:db.system',
comparator: '!=',
right: '""',
},
],
};
This PR adds a way for users to select a predefined test spec snippet so they have a quick start when adding checks for a trace
Changes
Fixes
Checklist
https://www.loom.com/share/dee7d821ab7d4bb1b4f53d81659e02c3