Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add error handling for trigger section #2274

Merged
merged 3 commits into from
Mar 31, 2023
Merged

feat(frontend): add error handling for trigger section #2274

merged 3 commits into from
Mar 31, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Mar 29, 2023 •
edited
Loading

This PR includes the base models for the new TestRunEvents spec. It also includes the error handling improvements related to the Test Run Trigger section.

Changes

  • Base models + API call for TestRunEvents
  • Error handling improvements for Test Run Trigger section.

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom

https://www.loom.com/share/bc98601c5a014b1aaabdea5d12603033

@jorgeepc jorgeepc self-assigned this Mar 29, 2023
@jorgeepc jorgeepc marked this pull request as ready for review March 29, 2023 20:32
@jorgeepc jorgeepc requested a review from xoscar March 29, 2023 20:33
xoscar
xoscar approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job my dude 🔥

@jorgeepc jorgeepc merged commit 174a398 into main Mar 31, 2023
@jorgeepc jorgeepc deleted the 2146-add-base-error-handling branch March 31, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Error Handling] - Trigger section improvements
2 participants
@jorgeepc @xoscar