fix: improvements to the test run events #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
commented
Apr 18, 2023
| @@ -208,7 +208,7 @@ func (e *defaultAssertionRunner) emitFailedAssertions(ctx context.Context, req A | |||
| } | |||
|
|
|||
| if errors.Is(spanAssertionResult.CompareErr, expression.ErrInvalidSyntax) { | |||
| e.eventEmitter.Emit(ctx, events.TestSpecsAssertionError( | |||
There was a problem hiding this comment.
Moving this from errors to warnings as these don't stop the test run
xoscar
commented
Apr 18, 2023
|
|
||
| err = pe.eventEmitter.Emit(request.ctx, events.TraceFetchingStart(request.test.ID, request.run.ID)) | ||
| if err != nil { | ||
| log.Printf("[PollerExecutor] Test %s Run %d: failed to emit TraceFetchingStart event: error: %s\n", request.test.ID, request.run.ID, err.Error()) |
There was a problem hiding this comment.
Moving some events ideally this file should only trigger "polling" specific events
xoscar
commented
Apr 18, 2023
| @@ -141,12 +141,14 @@ func (tp tracePoller) processJob(job PollingRequest) { | |||
| } | |||
|
|
|||
| if job.IsFirstRequest() { | |||
| err := tp.eventEmitter.Emit(job.ctx, events.TracePollingStart(job.test.ID, job.run.ID)) | |||
There was a problem hiding this comment.
As main orchestrator, here we should trigger fetching trace events
xoscar
commented
Apr 18, 2023
| <S.Column> | ||
| <S.InfoIcon /> | ||
| <div> | ||
| <Typography.Title level={3}>Polling profile configuration:</Typography.Title> |
There was a problem hiding this comment.
Adding polling profile info
danielbdias
approved these changes
Apr 18, 2023
server/executor/poller_executor.go
Outdated
| log.Printf("[PollerExecutor] Test %s Run %d: failed to emit TraceFetchingStart event: error: %s\n", request.test.ID, request.run.ID, err.Error()) | ||
| err = pe.eventEmitter.Emit(request.ctx, events.TracePollingStart(request.test.ID, request.run.ID)) | ||
| if err != nil { | ||
| log.Printf("[PollerExecutor] Test %s Run %d: failed to emit TraceFetchingStart event: error: %s\n", request.test.ID, request.run.ID, err.Error()) |
There was a problem hiding this comment.
Suggested change
| log.Printf("[PollerExecutor] Test %s Run %d: failed to emit TraceFetchingStart event: error: %s\n", request.test.ID, request.run.ID, err.Error()) | |
| log.Printf("[PollerExecutor] Test %s Run %d: failed to emit TracePollingStart event: error: %s\n", request.test.ID, request.run.ID, err.Error()) |
server/executor/trace_poller.go
Outdated
| @@ -123,7 +123,7 @@ func (tp tracePoller) Stop() { | |||
| func (tp tracePoller) Poll(ctx context.Context, test model.Test, run model.Run) { | |||
| log.Printf("[TracePoller] Test %s Run %d: Poll\n", test.ID, run.ID) | |||
|
|
|||
| job := NewPollingRequest(ctx, test, run, 0) | |||
| job := NewPollingRequest(ctx, test, run, 1) | |||
There was a problem hiding this comment.
Can we put this number as a constant on this file? Something like PollingRequestStartIteration ?
Suggested change
| job := NewPollingRequest(ctx, test, run, 1) | |
| job := NewPollingRequest(ctx, test, run, PollingRequestStartIteration) |
xoscar
deleted the
2400-error-handling-fix-event-logs-for-the-polling-mechanism
branch
jorgeepc
approved these changes
Apr 19, 2023
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
* fix: improvements to the test run events * PR comment updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several improvements to the events triggered by the BE when executing a test run
Changes
Fixes
Checklist
I Encourage you to take a look at the loom video
https://www.loom.com/share/9353520fe43c49c6897f26b45975c2c3