Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer tracetest dev docker warning and add options to run installer directly without user input. #2462

Merged
merged 2 commits into from
May 2, 2023

Conversation

danielbdias
Copy link
Contributor

@danielbdias danielbdias commented Apr 28, 2023

This PR removes a warning that users receive when trying to install Tracetest with docker (as shown on the image below) and add two optional params to skip user input on tracetest server install.
image

Changes

  • Added empty "TRACETEST_DEV" env when reading docker-compose for the first time to avoid warning
  • Adding arguments to avoid user input when running CLI

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@danielbdias danielbdias changed the title Fix installer tracetest dev docker warning Fix installer tracetest dev docker warning and add options to run installer directly without user input. Apr 28, 2023
Comment on lines +328 to +330
Environment: map[string]string{
"TRACETEST_DEV": "",
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change of this PR to avoid warnings. We use the same set of tools as docker-compose, which emits a warning on loader.Load even if we are not running the containers.

Copy link
Collaborator

@schoren schoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielbdias danielbdias merged commit 5282b36 into main May 2, 2023
@danielbdias danielbdias deleted the fix/installer-tracetest-dev-docker-warning branch May 2, 2023 14:30
schoren pushed a commit that referenced this pull request Jun 5, 2023
…taller directly without user input. (#2462)

* Adding options to run installer with previously chosen options

* Adding empty TRACETEST_DEV env when loading docker-compose on installation to avoid warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants