Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix order of fields when listing resources #2474

Merged
merged 10 commits into from
May 8, 2023
Merged

fix order of fields when listing resources #2474

merged 10 commits into from
May 8, 2023

Conversation

mathnogueira
Copy link
Member

This PR fixes the order of the fields when listing resources. All fields would be sorted alphabetically, when they should have a logical order (based on the backend structs).

Before:

count: 1
items:
    - spec:
          createdat: "2023-04-27T20:15:24.383412Z"
          description: ""
          id: production
          name: Production
          values:
              - key: HOST
                value: http://localhost
              - key: PORT
                value: "11633"
      type: Environment

After:

count: 1
items:
    - type: Environment
      spec:
          id: production
          name: Production
          description: ""
          createdat: "2023-04-27T20:15:24.383412Z"
          values:
              - key: HOST
                value: http://localhost
              - key: PORT
                value: "11633"

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

xoscar
xoscar approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! 🔥

@mathnogueira mathnogueira force-pushed the fix/environment-resource-yaml branch from f90a2e4 to 0058617 Compare May 5, 2023 18:12
@mathnogueira mathnogueira merged commit 5e35e36 into main May 8, 2023
@mathnogueira mathnogueira deleted the fix/environment-resource-yaml branch May 8, 2023 15:40
schoren pushed a commit that referenced this pull request May 9, 2023
@mathnogueira @schoren
fix order of fields when listing resources (#2474)
88791b1 
* fix order of fields when listing resources

* fix tests

* adapt resource manager to replace mapstructure with yaml decoding

* patch polling profiles

* patch demos

* patch data stores

* patch config resource

* patch provisioner to use new yaml library and fix test data

* fix resource manager mocked tests
schoren pushed a commit that referenced this pull request Jun 5, 2023
@mathnogueira @schoren
fix order of fields when listing resources (#2474)
871a442 
* fix order of fields when listing resources

* fix tests

* adapt resource manager to replace mapstructure with yaml decoding

* patch polling profiles

* patch demos

* patch data stores

* patch config resource

* patch provisioner to use new yaml library and fix test data

* fix resource manager mocked tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar xoscar approved these changes

@jorgeepc jorgeepc jorgeepc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathnogueira @jorgeepc @xoscar @danielbdias