Update CLI e2e test engine to support CLI debug and add error handling for 404 errors on Get #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2537) Update concepts/transactions.md: «Tests A and B» instead of «Transactions A and B»
* Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> --------- Co-authored-by: Adnan Rahić <[email protected]>
danielbdias
force-pushed
the
add/cli-e2e-tests-to-environments
branch
from
530c941
to
1c79fa4
Compare
schoren
requested changes
May 23, 2023
server/environment/manager.go
Outdated
Comment on lines
94
to
97
| if err != nil && errors.Is(err, sql.ErrNoRows) { | ||
| // this is a new environment, and we should create it | ||
| return r.Create(ctx, environment) | ||
| } |
There was a problem hiding this comment.
This looks like it's trying to upsert envs. can we remove it?
Suggested change
| if err != nil && errors.Is(err, sql.ErrNoRows) { | |
| // this is a new environment, and we should create it | |
| return r.Create(ctx, environment) | |
| } |
schoren
approved these changes
May 23, 2023
danielbdias
added a commit
that referenced
this pull request
May 23, 2023
…g for 404 errors on Get (#2573)
danielbdias
added a commit
that referenced
this pull request
May 25, 2023
* Add documentation about mapped CLI e2e to do * Apply suggestions from code review Co-authored-by: Julianne Fermi <[email protected]> * fix(docs): fix docs related to data stores (#2558) * Updating Kubernetes installation docs (#2562) * Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> --------- Co-authored-by: Adnan Rahić <[email protected]> * docs(install-deploy): improves Deployment and Getting Started pages (#2567) * docs(deployment): clean up formatting * docs(detailed-install): improved explanation, added link to Helm docs * chore: upgrade goreleaser version to v1.18.2 (#2572) * feat: migrate transactions to new resourcemanager architecture (#2551) * feat: support dashes in attribute names (#2569) * Update CLI e2e test engine to support CLI debug and add error handling for 404 errors on Get (#2573) * hotfix: fix controller (#2574) * Improve test output and remove parallelism (#2575) --------- Co-authored-by: Julianne Fermi <[email protected]> Co-authored-by: Jorge Padilla <[email protected]> Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Sebastian Choren <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
…g for 404 errors on Get (#2573)
schoren
added a commit
that referenced
this pull request
Jun 5, 2023
* Add documentation about mapped CLI e2e to do * Apply suggestions from code review Co-authored-by: Julianne Fermi <[email protected]> * fix(docs): fix docs related to data stores (#2558) * Updating Kubernetes installation docs (#2562) * Updating Kubernetes installation docs * Apply suggestions from code review Co-authored-by: Adnan Rahić <[email protected]> --------- Co-authored-by: Adnan Rahić <[email protected]> * docs(install-deploy): improves Deployment and Getting Started pages (#2567) * docs(deployment): clean up formatting * docs(detailed-install): improved explanation, added link to Helm docs * chore: upgrade goreleaser version to v1.18.2 (#2572) * feat: migrate transactions to new resourcemanager architecture (#2551) * feat: support dashes in attribute names (#2569) * Update CLI e2e test engine to support CLI debug and add error handling for 404 errors on Get (#2573) * hotfix: fix controller (#2574) * Improve test output and remove parallelism (#2575) --------- Co-authored-by: Julianne Fermi <[email protected]> Co-authored-by: Jorge Padilla <[email protected]> Co-authored-by: Adnan Rahić <[email protected]> Co-authored-by: Sebastian Choren <[email protected]> Co-authored-by: Matheus Nogueira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
Checklist