feature(cli): adding server and cli version match #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoscar
requested review from
mathnogueira and
jorgeepc
and removed request for
schoren,
mathnogueira,
jorgeepc and
danielbdias
mathnogueira
approved these changes
May 29, 2023
jorgeepc
approved these changes
May 29, 2023
danielbdias
approved these changes
May 29, 2023
…nd-cli-version-match
adnanrahic
approved these changes
May 29, 2023
xoscar
deleted the
2298-cli-improvements-validate-that-server-and-cli-version-match
branch
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
* feature(cli): adding server and cli version match * feature(cli): adding server and cli version match * feature(cli): adding stdout resulkt * feature(cli): adding server and cli version match * feature(cli): adding server env for version test * fixing tests * feature(cli): updating version mismatch error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a server version match for the CLI. It automatically breaks any command if we find a mismatch.
It is skipped if the
TRACETEST_DEVflag is set.Changes
Fixes
Checklist
https://www.loom.com/share/b09b566e12664f49bfcdcda73a079576