Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): fix grpc test spec snippet #2605

Merged
merged 1 commit into from
May 29, 2023
Merged

fix(frontend): fix grpc test spec snippet #2605

merged 1 commit into from
May 29, 2023

Conversation

jorgeepc
Copy link
Contributor

This PR fixes the attribute in the Test Spec snippet for All gRPC Spans: Status is Ok

Changes

  • fix attribute in test spec snippet

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2023-05-29 at 11 22 55

@jorgeepc jorgeepc self-assigned this May 29, 2023
@jorgeepc jorgeepc requested a review from xoscar May 29, 2023 16:26
@jorgeepc jorgeepc merged commit 8a0508f into main May 29, 2023
@jorgeepc jorgeepc deleted the 2601-fix-grpc-test-spec-snippet branch May 29, 2023 17:02
schoren pushed a commit that referenced this pull request Jun 5, 2023
@jorgeepc @schoren
fix(frontend): fix grpc test spec snippet (#2605)
3bc37c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbdias danielbdias danielbdias approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snippet for testing grpc status codes is wrong
3 participants
@jorgeepc @xoscar @danielbdias