fix: make resource manager take server prefix into consideration #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
approved these changes
Jun 1, 2023
|
@mathnogueira can you add some kind of test for for this? I wouldn't like to have a regression on this |
mathnogueira
commented
Jun 1, 2023
| @@ -63,3 +70,19 @@ func getTests(t *testing.T, endpoint string) []openapi.Test { | |||
|
|
|||
| return tests | |||
| } | |||
|
|
|||
| func getDatastores(t *testing.T, endpoint string) resourcemanager.ResourceList[datastoreresource.DataStore] { | |||
There was a problem hiding this comment.
Used the datastores API to check if the resource manager is considering the path prefix
schoren
approved these changes
Jun 1, 2023
xoscar
approved these changes
Jun 1, 2023
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
* fix: make resource manager take server prefix in consideration * check if datastore endpoint (managed resource) consider path prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the resource manager take the server path prefix into consideration when building the routes. Related to one problem related in #2565
Checklist