-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): fix analyzer results in trace DAG #2674
Conversation
Thank you @jorgeepc for the update, looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jorgeepc great job man!
import * as S from './SpanNode.styled'; | ||
|
||
interface IProps extends NodeProps<INodeDataSpan> {} | ||
|
||
const SpanNode = ({data, id, selected}: IProps) => { | ||
const dispatch = useAppDispatch(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to consider cleaning up nodes to not have to be connected to all of this state and such, maybe something to think latter on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agree with that. I have been thinking about that for a while. We need to parse everything (span related) and inject it in the data object.
This PR includes multiples fixes/improvements for the Trace Analyzer results in the DAG:
Analyzer errors
componentAnalyzer errors
component and theSpan node
Changes
Analyzer errors
componentAnalyzer errors
component and theSpan node
Fixes
Checklist
Loom
https://www.loom.com/share/40bc665d8ec3484b9b168d8706666150