Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): update help menu #2689

Merged
merged 3 commits into from
Jun 9, 2023
Merged

feat(frontend): update help menu #2689

merged 3 commits into from
Jun 9, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jun 8, 2023 •
edited
Loading

This PR updates the help menu in the header component.

Changes

  • migrate the help menu to a dropdown component
  • implement new look&feel for the menu

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Now

Screenshot 2023-06-09 at 09 55 04

Before

Screenshot 2023-06-08 at 15 22 03

@jorgeepc jorgeepc self-assigned this Jun 8, 2023
@jorgeepc jorgeepc marked this pull request as ready for review June 8, 2023 20:25
@jorgeepc jorgeepc requested a review from xoscar June 8, 2023 21:33
xoscar
xoscar approved these changes Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jorgeepc jorgeepc merged commit 90472ba into main Jun 9, 2023
@jorgeepc jorgeepc deleted the 2419-update-help-menu branch June 9, 2023 16:31
@jorgeepc jorgeepc mentioned this pull request Jun 9, 2023
Closed
mathnogueira pushed a commit that referenced this pull request Jun 13, 2023
@jorgeepc @mathnogueira
feat(frontend): update help menu (#2689)
09ff862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeepc @xoscar