Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): add no matches message in trace search #2690

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jun 8, 2023

This PR adds the No matches found message when performing a Trace search and no results are available.

Changes

  • new not found message

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshot

Screenshot 2023-06-08 at 16 08 29

@jorgeepc jorgeepc self-assigned this Jun 8, 2023
@jorgeepc jorgeepc marked this pull request as ready for review June 8, 2023 21:29
@jorgeepc jorgeepc requested a review from xoscar June 8, 2023 21:32
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jorgeepc jorgeepc merged commit cd7ed6e into main Jun 9, 2023
@jorgeepc jorgeepc deleted the 1154-fix-no-matched-spans branch June 9, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants