Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix missing dep in useEffect in TestSpec form #2696

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

jorgeepc
Copy link
Contributor

@jorgeepc jorgeepc commented Jun 9, 2023

This PR fixes a missing dependency in our TestSpec form that was causing a bug when trying to create a new spec from the attribute list using the same selector.

Changes

  • add missing dependency

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this Jun 9, 2023
@jorgeepc jorgeepc marked this pull request as ready for review June 9, 2023 17:35
@jorgeepc jorgeepc requested a review from xoscar June 9, 2023 17:35
Copy link
Collaborator

@xoscar xoscar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we just need to test the shit out of this one before releasing 😬

@jorgeepc jorgeepc merged commit 05e2327 into main Jun 9, 2023
@jorgeepc jorgeepc deleted the 2484-fix-test-spec-form branch June 9, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discard unsaved changes flow
2 participants