fix(server): standardizing datastore resource names #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoren
reviewed
Jun 22, 2023
| @@ -192,8 +192,8 @@ func (s *ResourceApiApiService) GetDataStore(ctx context.Context, dataStoreId st | |||
| // TODO - update GetDataStore with the required logic for this service method. | |||
| // Add api_resource_api_service.go to the .openapi-generator-ignore to avoid overwriting this service implementation when updating open api generation. | |||
|
|
|||
| //TODO: Uncomment the next line to return response Response(200, DataStoreResource{}) or use other options such as http.Ok ... | |||
| //return Response(200, DataStoreResource{}), nil | |||
| //TODO: Uncomment the next line to return response Response(200, datastore{}) or use other options such as http.Ok ... | |||
There was a problem hiding this comment.
should this be renamed? try running make generate to keep it in sync with the openapi files
There was a problem hiding this comment.
No 🤦 , I'm reverting this change.
schoren
reviewed
Jun 22, 2023
| @@ -12,7 +12,7 @@ package openapi | |||
| type DataStoreList struct { | |||
| Count int32 `json:"count,omitempty"` | |||
|
|
|||
| Items []DataStoreResource `json:"items,omitempty"` | |||
| Items []datastore `json:"items,omitempty"` | |||
danielbdias
force-pushed
the
update/stardardize-datastore-resource
branch
from
3b83f63
to
c7cefe5
Compare
schoren
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the names of the datastore resource files to a common standard that we defined with Tracetest Core contributors.
Changes
Checklist