feat(server): add yaml stream encoding for resource manager #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
approved these changes
Jun 24, 2023
server/resourcemanager/encoding.go
Outdated
|
|
||
| // getYamlstreamField returns the field in `target` with the name as the value of its yamlstream tag. | ||
| // it returns an error if the field is not found or if the field is not of the specified kind. | ||
| func getYamlstreamField(target interface{}, name string, kind reflect.Kind) (reflect.Value, error) { |
There was a problem hiding this comment.
Suggested change
| func getYamlstreamField(target interface{}, name string, kind reflect.Kind) (reflect.Value, error) { | |
| func getYamlStreamField(target interface{}, name string, kind reflect.Kind) (reflect.Value, error) { |
| @@ -149,3 +149,89 @@ name: example | |||
| }) | |||
|
|
|||
| } | |||
|
|
|||
| func TestYamlstreamEncoding(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| func TestYamlstreamEncoding(t *testing.T) { | |
| func TestYamlStreamEncoding(t *testing.T) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multi-document YAML requests and responses in the
resourcemanagerpackage. Previously, it supported single-document YAML.The implementations uses a new encoder that can be used with the
text/yaml-streamcontent-type/accept headers.With this change, we can handle requests and responses that contain multiple YAML documents separated by
---lines.This means that a client can send a multi document request and it will work, but only if all the documents are of the same type (i.e. all transactions, or all tests, but not a mix of transactions and tests).
See it in action:
https://www.loom.com/share/dee1b1c35a544ee3b31bd00f1058ab1c
Checklist